fix(typescript): add overload types for find service methods (#1972)

feathersjs · Jul 11, 2020 · ef55af0 · ef55af0
1 parent 9e7c0e1
commit ef55af0
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/packages/authentication-oauth/src/strategy.ts b/packages/authentication-oauth/src/strategy.ts
@@ -103,7 +103,8 @@ export class OAuthStrategy extends AuthenticationBaseStrategy {
       ...params,
       query
     });
-    const [ entity = null ] = result.data ? result.data : result;
+
+    const [ entity = null ] = Array.isArray(result) ? result : result.data
 
     debug('findEntity returning', entity);
 

diff --git a/packages/feathers/index.d.ts b/packages/feathers/index.d.ts
@@ -205,6 +205,22 @@ declare namespace createApplication {
     }
 
     interface ServiceOverloads<T> {
+        /**
+         * Retrieve all resources from this service.
+         *
+         * @param params - Service call parameters {@link Params}
+         * @see {@link https://docs.feathersjs.com/api/services.html#find-params|Feathers API Documentation: .find(params)}
+         */
+        find? (params: Params & { paginate: false}): Promise<T[]>
+
+        /**
+         * Retrieve all resources from this service.
+         *
+         * @param params - Service call parameters {@link Params}
+         * @see {@link https://docs.feathersjs.com/api/services.html#find-params|Feathers API Documentation: .find(params)}
+         */
+        find? (params?: Params): Promise<Paginated<T>>
+
         /**
          * Create a new resource for this service.
          *