Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support a secretProvider #1063

Merged
merged 3 commits into from
Oct 26, 2018
Merged

support a secretProvider #1063

merged 3 commits into from
Oct 26, 2018

Conversation

kevinranks
Copy link
Contributor

Hello,

I hope you accept this simple PR that adds support for a secretOrKeyProvider as documented at passport-jwt#usage.

The change simply checks if the passed secret is a function or not. It will then it will set the appropriate key (secretOrKey or secretOrKeyProvider) as defined in passport-jwt.

Thanks!

@daffl
Copy link
Member

daffl commented Oct 22, 2018

This makes sense, thank you. Could you also add the option in the documentation. How would a test for this look like?

@kevinranks
Copy link
Contributor Author

@daffl Can you rebuild this? Not sure why the client tests failed...

@daffl daffl merged commit 9da26ad into feathersjs:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants