Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for custom service events #133

Closed
daffl opened this issue Apr 10, 2015 · 9 comments
Closed

Add documentation for custom service events #133

daffl opened this issue Apr 10, 2015 · 9 comments

Comments

@daffl
Copy link
Member

daffl commented Apr 10, 2015

#128 adds the functionality but the documentation has to be updated (now in the main repository because of #127).

@ekryski
Copy link
Contributor

ekryski commented Aug 5, 2015

This probably still needs to be added to the docs.

@daffl
Copy link
Member Author

daffl commented Aug 5, 2015

It does indeed. I didn't get the service.filter functionality into 1.1 though so custom events are not too useful since they get dispatched to all clients without a way to filter it.

@marshallswain
Copy link
Member

I've set up a placeholder for this here: https://github.com/feathersjs/feathers-docs/blob/master/05_events.md#custom-events

@daffl
Copy link
Member Author

daffl commented Feb 7, 2016

This has been added at http://docs.feathersjs.com/clients/readme.html#custom-events

@daffl daffl closed this as completed Feb 7, 2016
@marshallswain
Copy link
Member

I think the service setup stuff belongs on the events page. But we would want to still show how the client can listen to custom service events on the clients page where you have it now. Something like:

If you're using custom events you can listen to them on the client like this...

@joeyzhao0113
Copy link

Does it support add custom event at runtime?

@daffl
Copy link
Member Author

daffl commented Mar 8, 2017

You can add services at runtime (that can have custom events) but not new events to an already registered service.

@zhaoyi0113
Copy link

Is there a way to support add events after service has been registered? Otherwise, is it support to unregister and register the service again when adding new events

@lock
Copy link

lock bot commented Feb 7, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants