Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Small type improvements #1624

Merged
merged 2 commits into from
Oct 26, 2019
Merged

Conversation

vonagam
Copy link
Member

@vonagam vonagam commented Oct 16, 2019

  • getStrategies in AuthenticationBase does not return undefined values.
  • export ConnectionEvent in @feathersjs/authentication.
  • Date.now() instead of new Date().getTime().
  • Add authenticated to Params definition.
  • Do not use _.get where simply getting property works.
  • Type numbered errors in @feathersjs/errors.
  • Continuing fix: Typings for express request and response properties #1609, extend express application type with feathers application.
  • Reverting one change in fix: Small improvements #1605, add AuthenticationService extends ServiceAddons<AuthenticationResult> to use .hooks and .publish on a service instance.
  • Type methods in a service.
  • Type httpMethod for express rest.

@daffl daffl changed the title fix: Small improvements fix: Small type improvements Oct 26, 2019
@daffl daffl merged commit 50162c6 into feathersjs:master Oct 26, 2019
@vonagam vonagam deleted the fix-minor-stuff branch December 15, 2019 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants