New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transport-commons): Properly delete route data #3433

Merged

daffl merged 2 commits into feathersjs:dove from nikitamorozov:fix-issue-3432

Feb 25, 2024

Contributor

nikitamorozov commented Feb 24, 2024 •

edited by daffl

Closes #3432

nikitamorozov and others added 2 commits

February 24, 2024 17:07


          Fix issue feathersjs#3432

3d047e3

feathersjs#3432


          Update router.ts

daffl changed the title ~~Fix issue #3432~~ fix(transport-commons): Properly delete route data

daffl approved these changes

View reviewed changes

Member

daffl commented Feb 25, 2024

Good catch and thank you for taking the time to add a test! For some reason I thought it would also delete the data node.

daffl merged commit af01bdb into feathersjs:dove

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment