-
-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service at root. '/' #728
Comments
Hey @daffl, would you mind reviewing this decision in light of the following use case: I am implementing an ActivityPub server and the root path (the domain) represents the person’s handle in the federated system. (So, e.g., I will be @ar.al and people will be able to mention me using my domain as a handle.) As such, under the W3C ActivityPub spec, other servers will hit https://ar.al expecting a GET response with an Actor object. Afaik, this is currently impossible to implement in Feathers without falling back to plain Express. (This is not a showstopper for me but it would be nice to have all routes under the same approach.) Currently, when I try to mount the route, I get:
IMHO, / should be a valid service path, representing the default service at the given domain. Thanks for your time + look forward to hearing your thoughts :) |
I would probably go with a middleware in that case. The problem with |
I like the |
Would also really like a way to do this. Use case for me is when implementing a HATEOAS endpoint were I would like the root entry to be able to send |
Registering a root service is now possible in version 3.3.0 or later via |
I'm experimenting with using feathers as a chassis for mirco-services. is it possible to have a service as the root route?
I'm running into errors with hooks... src\services[name][name].service.js:17 service.hooks(hooks);
TypeError: Cannot read property 'hooks' of undefined at Function.module.exports (...\src\services[NAME][NAME].service.js:17:11)
at Function.configure (...node_modules\feathers\lib\application.js:150:8)
at Function.module.exports (...\src\services\index.js:5:7)
....
Steps to reproduce
(First please check that this issue is not already solved as described
here)
Expected behavior
Tell us what should happen
Actual behavior
Tell us what happens instead
System configuration
Tell us about the applicable parts of your setup.
Module versions (especially the part that's not working):
NodeJS version:
Operating System:
Browser Version:
React Native Version:
Module Loader:
The text was updated successfully, but these errors were encountered: