Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koa version? #83

Closed
MathRobin opened this issue Jun 17, 2014 · 6 comments
Closed

Koa version? #83

MathRobin opened this issue Jun 17, 2014 · 6 comments

Comments

@MathRobin
Copy link

Hi guys! Thank for your work!

Is there will be a version compatible for Koa framework. Koa is the Express future, designed by the express team with EcmaScript 6 features...

Things are a few different but the change is really interesting. Do you think about a migration/fork for it?

I use Koa, performances are awesome in comparison of express. Fork feathers for it could be awesome too

@daffl
Copy link
Member

daffl commented Jun 17, 2014

This came up in #58 before. I put my thoughts in there but basically I'd be interested in implementing Feathers using ES6 but probably after the Harmony features landed in an official Node release. This probably won't be based directly on Koa but it will be used for the REST wrapper (although I don't think that the new way of doing things™ in Koa will be beneficial to the Feathers service concept).

The ES 6 features I think Feathers will need are Classes, Promises, Proxies and Generators:

class TodoService {
  constructor (app, path) {
    this.app = app;
  }

  find (params) {

  },

  get (id) {
    return new Promise((resolve, reject) => {
      resolve({
        id: id,
        description: 'You have to do ' + id
      });
    });
  },

  create (data, params) {

  },

  update (id, data, params) {

  },

  patch (id, data, params) {

  },

  remove (id, params) {

  }
}

@MathRobin
Copy link
Author

Sorry for the duplicate :s

@ekryski
Copy link
Contributor

ekryski commented Aug 5, 2015

No problem @MathRobin, thanks for weighing in!

@safizn
Copy link

safizn commented Feb 23, 2017

@daffl
How far is it from being decoupled from Express ? I would like to use Koa v2 with it.
Thanks

@marshallswain
Copy link
Member

@myuseringithub A Koa adapter needs to be created. feathers-rest is for Express. If you want to get started on it, you can check out the feathers-rest code and make something similar that will work for Koa.

@lock
Copy link

lock bot commented Feb 7, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants