Compare socket event data using lodash's isEqual instead of indexOf

[rlunden]

When running feathers-sync we had an issue with websockets being triggered with null values when bulk patching:

await context.app.service('foo').patch(
  null,
  {
    text: 'foo'
  },
  {
    query: { // some query }
  }
);

Without feathers-sync this will properly send out one socket event for each affected row in the foo service. However with feathers-sync active the sockets would instead be sent out with null as their data instead of the actual object.

See issue previously reported and closes feathersjs-ecosystem/feathers-sync#96

Upon further investigation it seems the issue is not technically in feathers-sync but in transport-commons. The issue seems to be that getDispatcher uses indexOf when trying to get individual item to dispatch. This normally works fine because the check that indexOf performs under the hood will check the reference and without feathers-sync the references will always match. However, the way feathers-sync works is that it will JSON.stringify the object and then JSON.parse the object thus creating a new reference. So indexOf will then return false and no data will be found for the socket to emit.

We fixed this by using lodash's isEqual with .find to find the correct individual item to dispatch. In our limited testing this seems to fix the issue when running feathers-sync while not breaking anything when running without feathers-sync.

[daffl]

Good catch, thank you! Will be published shortly.