Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to ES6 and API providers in separate modules #188

Merged
merged 3 commits into from Jan 4, 2016
Merged

Conversation

daffl
Copy link
Member

@daffl daffl commented Jan 3, 2016

This pull request migrates Feathers Core to ES6 using Babel and removed the API providers which are now in separate modules (#156).

Closes #156 and closes #183.

@@ -0,0 +1,57 @@
import _ from 'lodash';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we are ES6 we should be able to remove lodash pretty easily.

@ekryski
Copy link
Contributor

ekryski commented Jan 4, 2016

@daffl Nice work man. This makes the core so small. I ❤️ it so much!

I take back my comments about removing lodash. Pretty low priority because we are actually using it for some pretty legitimate stuff. Not just _.each.

:shipit:

@ekryski
Copy link
Contributor

ekryski commented Jan 4, 2016

I guess once we roll this out we should update the examples in the database adapters to use the ES6 syntax or possibly add an ES6 example alongside the old ones.

@marshallswain
Copy link
Member

Nice work! (like always:) So what's on the todo list before we merge this?

@daffl
Copy link
Member Author

daffl commented Jan 4, 2016

Documentation but I don't think that should block the merge. I started them in the https://github.com/feathersjs/feathers/tree/gh-pages-2.0 branch but didn't get that far. We need to do the reoganization we talked about, update all code samples to ES6 and add the topics that we'd like to cover and that are still missing.

Just for migration purposes we can just create a Gist that describes what is necessary (which should mostly just be replacing app.configure(feathers.rest()) etc. with var rest = require('feathers-rest'); app.configure(rest());).

@ekryski
Copy link
Contributor

ekryski commented Jan 4, 2016

Yes, and also how you initialize the database adapters. Let's merge this PR and then we'll do a whole swath of documentation updates.

ekryski added a commit that referenced this pull request Jan 4, 2016
Migration to ES6 and API providers in separate modules
@ekryski ekryski merged commit 6aa88c2 into master Jan 4, 2016
@ekryski ekryski deleted the es6 branch January 4, 2016 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Feathers core to ES6 Split feathers transports into their own modules
3 participants