feat(core): Remove Uberproto #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daffl
force-pushed
the
remove-uberproto
branch
from
f3e4040
to
7965bec
Compare
daffl
added a commit
that referenced
this pull request
Jan 5, 2021
BREAKING CHANGE: Services no longer extend Uberproto objects and `service.mixin()` is no longer available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes dependency on the dated Uberproto library which is a utility for ES5 inheritance. Instead, built-in JavaScript functionality (
Object.createandObject.assign) is now used together with the recommended ES6 classes.Everything will continue to work as is except for the
service.mixin()method, which will no longer be available (but can usually be replaced with a simpleObject.assign).