Fix additional query parameters causing issues #2398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the expressOauth code allows passing through more parameters than
redirect
, which all get lumped into an object calledquery
, this then gets put into the params object on the other end of the oauth flow for convenience.e.g.
https://mybackend.com/oauth/google?redirect=/checkout&cartId=1234
results in the following in params being available
{ redirect: '/checkout', query: { cartId: 1234 } }
The issue is that these params are passed directly into the patch/get/create service method calls in the strategy, so then the query is used to filter the patch request and an error is returned where the id is not found.
Omitting the query from the params fixes this issue.