[dove/hygen-cli] Name temp dirs like feathers_ts_koa #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of test folders being named like this: ``` drwx------ 7 sandbox sandbox 4.0K Oct 5 20:53 feathers-O7C15n drwx------ 7 sandbox sandbox 4.0K Oct 5 20:53 feathers-GGIGRy drwx------ 7 sandbox sandbox 4.0K Oct 5 20:52 feathers-cz5zXe drwx------ 7 sandbox sandbox 4.0K Oct 5 20:52 feathers-eQiVHK drwx------ 7 sandbox sandbox 4.0K Oct 5 20:49 feathers-ewzTXi drwx------ 7 sandbox sandbox 4.0K Oct 5 20:43 feathers-qRmKUw drwx------ 7 sandbox sandbox 4.0K Oct 5 20:41 feathers-HyM5uj drwx------ 7 sandbox sandbox 4.0K Oct 5 20:37 feathers-ZgnC7M drwx------ 7 sandbox sandbox 4.0K Oct 5 20:31 feathers-IIUqZJ ``` Names them like this: ``` drwx------ 8 sandbox sandbox 4.0K Oct 5 21:09 feathers_ts_koa-fxVBjf drwx------ 7 sandbox sandbox 4.0K Oct 5 21:07 feathers_ts_express-Nj0Nfm drwx------ 7 sandbox sandbox 4.0K Oct 5 21:07 feathers_js_express-3A31J1 drwx------ 7 sandbox sandbox 4.0K Oct 5 21:06 feathers_js_koa-DPoCLs ``` Also kindof "addresses" the github timing out problem... by running the dev suite of tests if on github
|
Good call this makes much more sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of test folders being named like this:
Names them like this:
why the tests are failing: 5 minute time out... in a project with thousands of tests