Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): result resolver correctly resolves paginated find result #2594

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

idaho
Copy link
Contributor

@idaho idaho commented Apr 7, 2022

Summary

This pull request will resolves an issue with the resultResolver in combination with a paginated services.

Currently the schema resultResolver resolves the result on context.data. This will end up in an issue if you have a service configured with pagination enabled.

Before the resultResolver is running we have the properties total, limit, skip and data on context.result. After all properties are resolved, the result of it will set to context.result. That means, that the paginated result structure gets los.

@daffl daffl merged commit 6511e45 into feathersjs:dove Apr 11, 2022
@daffl
Copy link
Member

daffl commented Apr 11, 2022

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants