New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commited is boolean type #3458

Merged

daffl merged 2 commits into feathersjs:dove from AshotN:patch-4

Apr 10, 2024

Contributor

AshotN commented Apr 10, 2024

Summary

The docs for transaction specify committed as either true or false but the type is any

AshotN added 2 commits

April 10, 2024 01:33


          Commited is boolean type

98bb1f8

The docs https://feathersjs.com/api/databases/knex#transactions say that committed is either true or false


          commited is a promise

11ddb35

daffl approved these changes

View reviewed changes

daffl merged commit 5fa4dbc into feathersjs:dove

2 checks passed

AshotN deleted the patch-4 branch

April 11, 2024 02:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment