fix(hooks): Add toJSON to hook context (#108)

feathersjs · Feb 10, 2023 · 03e5883 · 03e5883
1 parent d1ba68f
commit 03e5883
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/main/hooks/src/base.ts b/main/hooks/src/base.ts
@@ -15,6 +15,22 @@ export class BaseHookContext<C = any> {
   constructor(data: HookContextData = {}) {
     Object.assign(this, data);
   }
+
+  toJSON() {
+    const keys = Object.keys(this);
+    let proto = Object.getPrototypeOf(this);
+
+    while (proto) {
+      keys.push(...Object.keys(proto));
+      proto = Object.getPrototypeOf(proto);
+    }
+
+    return keys.reduce((result: this, key: string) => {
+      result[key] = this[key];
+
+      return result;
+    }, {} as this);
+  }
 }
 
 export interface HookContext<T = any, C = any> extends BaseHookContext<C> {

diff --git a/main/hooks/test/class.test.ts b/main/hooks/test/class.test.ts
@@ -24,10 +24,12 @@ it('hooking object on class adds to the prototype', async () => {
   hooks(DummyClass, {
     sayHi: middleware([
       async (ctx: HookContext, next: NextFunction) => {
-        assertEquals(ctx.arguments, ['David']);
-        assertEquals(ctx.method, 'sayHi');
-        assertEquals(ctx.name, 'David');
-        assertEquals(ctx.self, instance);
+        assertEquals(ctx.toJSON(), {
+          arguments: ['David'],
+          method: 'sayHi',
+          name: 'David',
+          self: instance,
+        });
 
         await next();