Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix some errors for feathers integration #67

Merged
merged 15 commits into from
Dec 11, 2020
Merged

fix: fix some errors for feathers integration #67

merged 15 commits into from
Dec 11, 2020

Conversation

bertho-zero
Copy link
Collaborator

No description provided.

@bertho-zero bertho-zero mentioned this pull request Nov 21, 2020
Merged
daffl
daffl approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@daffl daffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! Just two not super critical comments.

packages/hooks/src/base.ts Outdated Show resolved Hide resolved
packages/hooks/src/base.ts Outdated Show resolved Hide resolved
@bertho-zero
Copy link
Collaborator Author

hooks/packages/hooks/src/base.ts

Line 19 in 6de77a1

Object.assign(this, data);

hooks/packages/hooks/src/base.ts

Line 118 in 6de77a1

return Object.assign({}, previous, this._props);

Should these Object.assign be replaced by copyProperties ?

@daffl daffl merged commit fcfc0ca into master Dec 11, 2020
@daffl daffl deleted the bugfixs branch December 11, 2020 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daffl daffl daffl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bertho-zero @daffl