Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade @feathersjs/hooks #2134

Merged
merged 3 commits into from
Dec 11, 2020
Merged

Conversation

bertho-zero
Copy link
Collaborator

Works with feathersjs/hooks#67

@daffl daffl merged commit f99a380 into feathersjs:dove Dec 11, 2020
@daffl
Copy link
Member

daffl commented Dec 11, 2020

Awesome. Hopefully getting out a new pre-release this weekend!

@daffl
Copy link
Member

daffl commented Dec 17, 2020

This has been published in v5.0.0-pre.1 for beta testing. I'm wondering if we should have another pass to use the @feathersjs/hooks functionality more directly (instead of e.g. keeping service.__hooks around). This might also play into some other changes like

  • Removing Uberproto and instead using ES6 classes and Object.create to extend service (started looking into that yesterday but had to look into some other things to wrap up)
  • Another TypeScript refactoring pass turning the Application from a mixin into a class and improving service, configuration (app.get) and hook context type-ability
  • Allowing custom methods on all transports (discussion in Custom methods the Feathers way #1976)

@bertho-zero
Copy link
Collaborator Author

bertho-zero commented Dec 18, 2020

The mixin on services is only used to return the context if we have true as the last argument, we can remove it to rely only on @feathersjs/hooks.

However, I don't see how to remove Uberproto for the Express app merge in the Feathers app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants