Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User guide review for fresh eyes #160

Closed
hangfei opened this issue Apr 25, 2022 · 2 comments · Fixed by #188
Closed

User guide review for fresh eyes #160

hangfei opened this issue Apr 25, 2022 · 2 comments · Fixed by #188
Labels
good first issue Good for newcomers

Comments

@hangfei
Copy link
Collaborator

hangfei commented Apr 25, 2022 •
edited

We just added quite a few wikis, and tutorials. It's good to have some new users that have never used Feathr try it out.
Review the user guide by new users so we know if it's easy to understand and onboard(from easy to hard).

  • Read the documentations to see if it's easy enough to understand
  • If there is something not well-explained or missing, try to fix them or raise a issue with us.

Here are the documentations:
https://github.com/linkedin/feathr/blob/main/docs/concepts/feathr-concepts-for-beginners.md

https://github.com/linkedin/feathr/blob/main/docs/concepts/feathr-capabilities.md

https://github.com/linkedin/feathr/blob/main/docs/concepts/feature-definition.md

https://github.com/linkedin/feathr/blob/main/docs/concepts/feature-generation.md

https://github.com/linkedin/feathr/blob/main/docs/concepts/feature-join.md

https://github.com/linkedin/feathr/blob/main/docs/concepts/point-in-time-join.md
@hangfei hangfei added the good first issue Good for newcomers label Apr 25, 2022
@hangfei hangfei mentioned this issue Apr 25, 2022
Open
@ahlag ahlag mentioned this issue Apr 28, 2022
Merged
@ahlag
Copy link
Contributor

ahlag commented Apr 28, 2022 •
edited

@hangfei

Current Progress

Feedback (Absolute beginner. Please correct or guide me if I am wrong)

feathr concepts

  1. Want to clear up my understanding of Source vs INPUT_CONTEXT
    INPUT_CONTEXT is used when we want to define features from Observation Data a.k.a streaming data e.g. user_click_stream_table while Source refers to data usually a master data e.g. user_profile_table, user_historical_buying_table and etc in data lakes e.g. S3, Azure Blob Storage and Hadoop.

feature join

  1. Just curious. Is joining different column names as the join key in the feature join doc intentional?
    https://github.com/linkedin/feathr/blob/3b6449155114aca385608c187137fac78255ec0f/docs/concepts/feature-join.md?plain=1#L18
    https://github.com/linkedin/feathr/blob/3b6449155114aca385608c187137fac78255ec0f/docs/concepts/feature-join.md?plain=1#L27

  2. The example below would be easier to understand if it relates to the example given in Intuitions of Frame Join
    https://github.com/linkedin/feathr/blob/3b6449155114aca385608c187137fac78255ec0f/docs/concepts/feature-join.md?plain=1#L62-L70

feature capabilities

  1. Does the KafkaSource support EventHub?
    https://github.com/linkedin/feathr/blob/3b6449155114aca385608c187137fac78255ec0f/docs/concepts/feathr-capabilities.md?plain=1#L144-L148

  2. Support for AWS and GCP? Is Feathr currently an Azure-only OSS? A lot of the terms used are Azure native services so I was curious.

feature capabilities

  1. Feature leakage in point in time join but Data leakage in feathr concepts

@hangfei
Copy link
Collaborator Author

hangfei commented Apr 28, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed spelling for user guide
2 participants
@hangfei @ahlag