Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data source issue #1070

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Fix data source issue #1070

merged 2 commits into from
Feb 15, 2023

Conversation

rakeshkashyap123
Copy link
Collaborator

Datasource loading should happen from the source data only. The pathInfo path should not be sent to load the data.

jaymo001
jaymo001 previously approved these changes Feb 14, 2023
Copy link
Collaborator

@bozhonghu bozhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@anirudhagar13 anirudhagar13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enya-yx enya-yx added the safe to test Tag to execute build pipeline for a PR from forked repo label Feb 15, 2023
@jaymo001 jaymo001 merged commit 98db719 into main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants