Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade actions/checkout version from v2 to v3 to clean up node 12 deprecated warnings #1110

Merged
merged 1 commit into from
Mar 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/document-scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ jobs:
check-links:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Checkout
uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v3
with:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/gradle-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ jobs:
gradle_test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Checkout
uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Set up JDK 8
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/publish-to-azure-storage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,17 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Checkout source
uses: actions/checkout@v2
- name: Checkout
uses: actions/checkout@v3

# Setting up JDK 8, this is required to build Feathr
# Setting up JDK 8, this is required to build Feathr
- name: Set up JDK 8
uses: actions/setup-java@v2
with:
java-version: "8"
distribution: "temurin"

# Publish Released Fat Jar to Blob Storage
# Publish Released Fat Jar to Blob Storage
- name: Gradle build
run: |
./gradlew build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-to-dockerhub.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
# Trigger Azure Web App webhooks to pull the latest nightly image
deploy:
runs-on: ubuntu-latest
needs: build_and_push_image_to_registry
needs: build_and_push_feathr_registry_image

steps:
- name: Deploy to Azure Web App feathr-registry-purview
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/publish-to-maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Checkout source
uses: actions/checkout@v2
- name: Checkout
uses: actions/checkout@v3

# Setting up JDK 8, this is required to build Feathr
# Setting up JDK 8, this is required to build Feathr
- name: Set up JDK 8
uses: actions/setup-java@v2
with:
Expand All @@ -25,9 +25,9 @@ jobs:
gpg-private-key: ${{ secrets.MAVEN_GPG_PRIVATE_KEY }}
gpg-passphrase: ORG_GRADLE_PROJECT_signingInMemoryKeyPassword

# CI release command defaults to publishSigned
# Sonatype release command defaults to sonaTypeBundleRelease
# Changing env names as documented here - https://vanniktech.github.io/gradle-maven-publish-plugin/central/#secrets
# CI release command defaults to publishSigned
# Sonatype release command defaults to sonaTypeBundleRelease
# Changing env names as documented here - https://vanniktech.github.io/gradle-maven-publish-plugin/central/#secrets
- name: Gradle Build and Publish to Maven central
run: |
./gradlew publish
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish-to-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Checkout source
uses: actions/checkout@v2
- name: Checkout
uses: actions/checkout@v3

- name: Set up Python
uses: actions/setup-python@v2
Expand All @@ -29,7 +29,7 @@ jobs:
twine check --strict dist/*


# Build and upload to PyPI
# Build and upload to PyPI
- name: "Builds and uploads to PyPI"
run: |
cd ./feathr_project
Expand Down
15 changes: 10 additions & 5 deletions .github/workflows/pull_request_push_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ jobs:
# output2 - if changes for a PR contain registry files
output2: ${{ steps.filter_registry.outputs.registry }}
steps:
- uses: actions/checkout@v2
- name: Checkout
uses: actions/checkout@v3
- uses: dorny/paths-filter@v2
id: filter_src
with:
Expand All @@ -66,7 +67,8 @@ jobs:
runs-on: ubuntu-latest
if: github.event_name == 'schedule' || github.event_name == 'push' || github.event_name == 'pull_request' || (github.event_name == 'pull_request_target' && contains(github.event.pull_request.labels.*.name, 'safe to test'))
steps:
- uses: actions/checkout@v2
- name: Checkout
uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Set up JDK 8
Expand Down Expand Up @@ -134,7 +136,8 @@ jobs:
runs-on: ubuntu-latest
if: github.event_name == 'schedule' || github.event_name == 'push' || github.event_name == 'pull_request' || (github.event_name == 'pull_request_target' && contains(github.event.pull_request.labels.*.name, 'safe to test'))
steps:
- uses: actions/checkout@v2
- name: Checkout
uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Set up JDK 8
Expand Down Expand Up @@ -202,7 +205,8 @@ jobs:
runs-on: ubuntu-latest
if: github.event_name == 'schedule' || github.event_name == 'push' || github.event_name == 'pull_request' || (github.event_name == 'pull_request_target' && contains(github.event.pull_request.labels.*.name, 'safe to test'))
steps:
- uses: actions/checkout@v2
- name: Checkout
uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Set up JDK 8
Expand Down Expand Up @@ -260,7 +264,8 @@ jobs:
runs-on: ubuntu-latest
if: github.event_name == 'schedule' || github.event_name == 'push' || github.event_name == 'pull_request' || (github.event_name == 'pull_request_target' && contains(github.event.pull_request.labels.*.name, 'registry test'))
steps:
- uses: actions/checkout@v2
- name: Checkout
uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Set up JDK 8
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/ui-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ jobs:
name: eslint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Checkout
uses: actions/checkout@v3
- uses: reviewdog/action-eslint@v1
with:
eslint_flags: "src/"
Expand All @@ -28,7 +29,8 @@ jobs:
name: prettier_code_formatter
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2 # Check out the repository first.
- name: Checkout
uses: actions/checkout@v3
- uses: actionsx/prettier@v2
with:
# prettier CLI arguments.
Expand Down