Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: run black #1192

Merged
merged 2 commits into from
Jun 23, 2023
Merged

style: run black #1192

merged 2 commits into from
Jun 23, 2023

Conversation

atangwbd
Copy link
Collaborator

@atangwbd atangwbd commented Jun 23, 2023

Many files are not formatted correctly via the black formatter settings specified in pyproject.toml. This PR simply runs the black formatter on the feathr_project directory.

How was this PR tested?

As this is a code style/formatting PR, no tests are needed.

Does this PR introduce any user-facing changes?

  • [x ] No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

return s
elif isinstance(s, list):
return [to_camel(i) for i in s]
elif isinstance(s, dict):
return dict([(to_camel(k), s[k]) for k in s])


# TODO: need to update the other sources to make the code cleaner
# TODO: need to update the other sources to make the code cleaner

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
dataframeFromSpark = py4j_feature_job.loadSourceDataframe(job_param_java_array, set(feature_names_funcs.keys())) # TODO: Add data handler support here
dataframeFromSpark = py4j_feature_job.loadSourceDataframe(
job_param_java_array, set(feature_names_funcs.keys())
) # TODO: Add data handler support here

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
Copy link
Collaborator

@aabbasi-hbo aabbasi-hbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only formatting changes LGTM

@atangwbd atangwbd merged commit ed023a1 into main Jun 23, 2023
20 of 22 checks passed
@aabbasi-hbo aabbasi-hbo added the safe to test Tag to execute build pipeline for a PR from forked repo label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants