Containerizing ui and rest backend into one docker image #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blrchen
added
the
safe to test
|
Thanks! Can you add those steps in the documentation? |
jainr
previously approved these changes
Jun 20, 2022
Good suggestion. New dev doc added: How to build and push feathr registry docker image |
xiaoyongzhu
reviewed
Jun 22, 2022
docs/how-to-guides/build-and-push-feathr-registry-docker-image.md
Outdated
Show resolved
Hide resolved
jainr
previously approved these changes
Jun 22, 2022
Yuqing-cat
previously approved these changes
Jun 23, 2022
jainr
previously approved these changes
Jun 23, 2022
windoze
previously approved these changes
Jun 24, 2022
Yuqing-cat
approved these changes
Jun 24, 2022
windoze
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors docker files by containerizing ui and backend into one docker image, makes both docker image creation and deployment easier. Using nginx as a reversed proxy to route traffic to correct down streaming ui or backend.
Following test has been done for verification:
Build docker
docker build -t blrchen/feathr-sql-registry .Test locally
docker run --env CONNECTION_STR="Server=tcp:stripped-sqlname.database.windows.net,1433;Initial Catalog=testsql;Persist Security Info=False;User ID=stripped-username;Password=stripped-password;MultipleActiveResultSets=False;Encrypt=True;TrustServerCertificate=False;Connection Timeout=30;" --env API_BASE=api/v1 -it --rm -p 3000:80 blrchen/feathr-sql-registryThen run http://localhost:3000, both ui and rest api runs well
Test on cloud
Setup a web app with image blrchen/feathr-sql-registry, set AZURE_CLIENT_ID and AZURE_TENANT_ID, both ui and rest api can run well, https://blair-feathr-combined.azurewebsites.net
So far test has been done on sql registry, purview registry will be tested when @YihuiGuo 's new api is ready.
Update: the latest docker image has been published to feathrfeaturestore/sql-registry:latest and verified with deployment https://feathr-sql-registry.azurewebsites.net
Closes #345