Add COUNT_DISTINCT aggregation #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangfei
reviewed
Aug 19, 2022
src/test/scala/com/linkedin/feathr/offline/SlidingWindowAggIntegTest.scala
Outdated
Show resolved
Hide resolved
xiaoyongzhu
added
the
safe to test
xiaoyongzhu
reviewed
Aug 22, 2022
src/main/scala/com/linkedin/feathr/swj/aggregate/CountDistinctAggregate.scala
Outdated
Show resolved
Hide resolved
jaymo001
reviewed
Aug 22, 2022
src/test/scala/com/linkedin/feathr/offline/SlidingWindowAggIntegTest.scala
Outdated
Show resolved
Hide resolved
esadler-hbo
requested review from
jaymo001,
ahlag and
xiaoyongzhu
and removed request for
jaymo001,
ahlag and
xiaoyongzhu
xiaoyongzhu
approved these changes
Aug 22, 2022
jaymo001
approved these changes
Aug 22, 2022
ahlag
pushed a commit
to ahlag/feathr
that referenced
this pull request
Aug 26, 2022
* scala COUNT_DISTINCT aggregation * cr change comment table to match expected results * cr - fix comment * cr - remove showing df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add COUNT_DISTINCT aggregation in Feathr window aggregations.
How was this PR tested?
Does this PR introduce any user-facing changes?