Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] fix data source detail page in rbac registry #698

Merged
merged 1 commit into from
Sep 22, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions registry/access_control/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,10 @@ def get_project_datasources(project: str, access: UserAccess = Depends(project_r


@router.get("/projects/{project}/datasources/{datasource}", name="Get a single data source by datasource Id [Read Access Required]")
def get_project_datasource(project: str, datasource: str, requestor: User = Depends(project_read_access)) -> list:
def get_project_datasource(project: str, datasource: str, requestor: UserAccess = Depends(project_read_access)) -> list:
response = requests.get(url=f"{registry_url}/projects/{project}/datasources/{datasource}",
headers=get_api_header(requestor)).content.decode('utf-8')
ret = json.loads(response)

datasource_qualifiedName = ret['attributes']['qualifiedName']
validate_project_access_for_feature(
datasource_qualifiedName, requestor, AccessType.READ)
return ret
headers=get_api_header(requestor.user_name)).content.decode('utf-8')
return json.loads(response)


@router.get("/projects/{project}/features", name="Get features under my project [Read Access Required]")
Expand Down