-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model #769
Merged
Merged
Model #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This RB is to create data models based on proposal: https://microsoft-my.sharepoint.com/:w:/g/personal/djkim_linkedin_biz/EZspGt7jJlRAqHTICZg3UbcBgQQ_VncOgM48hKW--T8qkg?e=T4N3zw
Add data attributes to data models
LeBenHL
requested changes
Oct 25, 2022
* Added _scproxy necessary for MacOS Signed-off-by: changyonglik <theeahlag@gmail.com> * Changed to conditional import Signed-off-by: changyonglik <theeahlag@gmail.com> * Added comments Signed-off-by: changyonglik <theeahlag@gmail.com> Signed-off-by: changyonglik <theeahlag@gmail.com>
* Create consume-features.md * Update consume-features.md * rename docs * Update model-inference-with-feathr.md * Update README.md * update docs per feedback * Update streaming-source-ingestion.md * update docs * update docs * Update azure-deployment-arm.md * Update model-inference-with-feathr.md * add sign off message Signed-off-by: Xiaoyong Zhu xiaoyzhu@outlook.com * fix comments * Delete deploy-feathr-api-as-webapp.md * Update model-inference-with-feathr.md Signed-off-by: Xiaoyong Zhu xiaoyzhu@outlook.com
* Clean up after moving to LFAI Clean up after moving to LFAI * Update README.md
…image (feathr-ai#668) * Adding DevSkim linter to Github actions * Fix in ARM template to pull latest tagged release image from dockerhub * Removing dev skim file from this branch * Fixing linkedin org reference
* Added prettier documentation Signed-off-by: changyonglik <theeahlag@gmail.com> * Fixed prettier documentation Signed-off-by: changyonglik <theeahlag@gmail.com> Signed-off-by: changyonglik <theeahlag@gmail.com>
UI: Add data source detail page
* squash commit and avoid conflict * Revert legacy purview client issue * Fix typo * Remove auth from assink * Update aerospike guidance document * Chaneg port param to int
* extend rbac to support project id as input Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> * update registry docs and interface Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> * user name case sensitive hot fix Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
…al spark (feathr-ai#644) * local spark feature join job with local file * update local spark with udf support * add feature gen support in local spark * update test case * remove unused feature conf, update doc * expose master as input and refine local spark provider Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
…hr-ai#686) Fixes feathr-ai#685 Look at the screenshot in the issue with the fixes. Basically it seems for dockerhub images, we don't need to pass in the full URL (domain name) for the image name while publishing them to webapps.
* Update setup.py * Update setup.py * Update setup.py
…#667) * Apply 'aggregation_features' parameter to merge dataframes * modify test cases * modify test case filter rule to keep same results as before * add typekey check and improve previous changes * merge to main and quick change * revert change by mistake * Apply this parameter to HDSF sink and add comments * quick fix * quick improve Co-authored-by: Enya-Yx <enya@v-ellinlu-2.fareast.corp.microsoft.com> Co-authored-by: enya-yx <enya@7633599-06281.northamerica.corp.microsoft.com> Co-authored-by: enya-yx <enya@LAPTOP-NBH6175C.redmond.corp.microsoft.com>
* Fix icons in UI cannot auto scale (feathr-ai#737) * Fix home.css code style issue
* Expose 'timePartitionPattern' * add test case * Add test cases and docstring * delete local files * quick fix Co-authored-by: enya-yx <enya@LAPTOP-NBH6175C.redmond.corp.microsoft.com> Co-authored-by: enya-yx <enya@v-ellinlu-2.fareast.corp.microsoft.com>
* Update materializing-features.md * Update materializing-features.md
* Fix protobuf version * quick fix Co-authored-by: enya-yx <enya@v-ellinlu-2.fareast.corp.microsoft.com>
* Add some notes based on on-call issues * quick fix Co-authored-by: enya-yx <enya@v-ellinlu-2.fareast.corp.microsoft.com>
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
…nd msrest (feathr-ai#763) * Adding DevSkim linter to Github actions * Fix in ARM template to pull latest tagged release image from dockerhub * Removing dev skim file from this branch * Fixing linkedin org reference * Removing the docker index url from dockerhub image name as it seems to cause problem with the update * Adding to the right file, had a dockerhub workflow file with different name * Adding debug statements to test udf issue on Synapse * Adding more print statements * Pinning msrest version to work with pinned version of azure-core * Removing debug code from previous branch
…thr-ai#746) * unify python package version and enable env setting for scala version Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> * update docs and decouple maven version Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> * change version back to 0.8.0 to avoid conflicts Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> * fix typo Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
…#765) Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com> Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
* Add flag to enable generation non-agg features * Typo * Resolve comments
Signed-off-by: Yuqing Wei <weiyuqing021@outlook.com>
* Adding DevSkim linter to Github actions * Update docker-publish.yml * Update docker-publish.yml * Update docker-publish.yml * Update docker-publish.yml * Update docker-publish.yml * Update docker-publish.yml * Update docker-publish.yml * Update docker-publish.yml * Removing devskim file * Restructuring the Prod Reco sample * Adjusting headings * Minor changes * Removing changes to docker publish file * Addressing PR comments, moving Product recommendation notebook sample to Synapse folder since it is strongly tied to Synapse * Addressing PR comments * Fixing images * Removing the need to pass email id as we could directly compute object Id using az command, also making CLI instructions clearer that it is for advance users
* Update role-management page in UI (feathr-ai#751) * fix home.css LF file * fix RoleForm eslint warning * remove import dayjs Signed-off-by: Boli Guan <ifendoe@gmail.com> * Change components to arrow function. Signed-off-by: Boli Guan <ifendoe@gmail.com> Signed-off-by: Boli Guan <ifendoe@gmail.com>
* Add craco devDependencies Signed-off-by: Boli Guan <ifendoe@gmail.com> * Add classnames, @ant-design/icons,eslint-plugin.. dependencies. Signed-off-by: Boli Guan <ifendoe@gmail.com> * Update .editorconfig and .eslintrc * Update .editorconfig Signed-off-by: Boli Guan <ifendoe@gmail.com> Signed-off-by: Boli Guan <ifendoe@gmail.com>
…to the test pipeline yml (feathr-ai#773) Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com> Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
* Update _databricks_submission.py * Update feathr-configuration-and-env.md * Update feathr-configuration-and-env.md * Update _databricks_submission.py
hyingyang-linkedin
requested review from
blrchen and
donegjookim
as code owners
October 25, 2022 22:32
donegjookim
reviewed
Oct 27, 2022
LeBenHL
approved these changes
Oct 31, 2022
windoze
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked into the updated model classes, they look good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This RB is the following RB of Add Data Models
Based on doc
Changes in this RB:
Add attributes to data models
Update data model diagram to reflect attributes changes
How was this PR tested?
N/A
Does this PR introduce any user-facing changes?