Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc dead links #805

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Fix doc dead links #805

merged 1 commit into from
Nov 1, 2022

Conversation

blrchen
Copy link
Collaborator

@blrchen blrchen commented Oct 31, 2022

Description

This PR fixes dead links detected in latest ci run. The doc scan ci action has been updated to run on main only, as running this in PR frequently reports false alarm due to changes in CI not deployed.

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@blrchen blrchen merged commit 7ba8847 into main Nov 1, 2022
@blrchen blrchen deleted the blair/fix-dead-link branch November 1, 2022 03:13
loomlike pushed a commit to loomlike/feathr that referenced this pull request Nov 1, 2022
This PR fixes dead links detected in latest ci run. The doc scan ci action has been updated to run on main only, as running this in PR frequently reports false alarm due to changes in CI not deployed.
xiaoyongzhu pushed a commit that referenced this pull request Nov 23, 2022
* Fix xdist test error. Also make a small cleanup some codes

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>

* Revert "Revert 756 (#798)"

This reverts commit ff438f5.

* revert 798 (revert756 - example notebook refactor). Also add job_utils unit tests

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>

* Update test_azure_spark_e2e.py

* Fix doc dead links (#805)

This PR fixes dead links detected in latest ci run. The doc scan ci action has been updated to run on main only, as running this in PR frequently reports false alarm due to changes in CI not deployed.

* Improve UI experience and clean up ui code warnings (#801)

* Add DataSourcesSelect and FlowGraph and ResizeTable components. Fix all warning and lint issues.

Signed-off-by: Boli Guan <ifendoe@gmail.com>

* Add CardDescriptions component and fix ESlint warning.

Signed-off-by: Boli Guan <ifendoe@gmail.com>

* Update FeatureDetails page title.

Signed-off-by: Boli Guan <ifendoe@gmail.com>

* Rename ProjectSelect

Signed-off-by: Boli Guan <ifendoe@gmail.com>

Signed-off-by: Boli Guan <ifendoe@gmail.com>

* Add release instructions for Release Candidate (#809)

* Add release instructions for Release Candidate

* Add a section for release versioning

* Add a section for overall process triggered by the release manager

* Bump version to 0.9.0-rc1 (#810)

* Fix tests to use mocks and fix get_result_df's databricks behavior

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>

* fix tem file to dir

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>

* checkout the feature_derivations.py from main (it was temporally changed to goaround previous issues)

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>

* Remove old databricks sample notebook. Change pip install feathr from the github main branch to pickup the latest changes always

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>

* Fix config and get_result_df for synapse

* Fix generate_config to accept all the feathr env var config name

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>

* Add more pytests

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>

* Use None as default dataformat in the job_utils. Instead, set 'avro' as a default output format to the job tags from the client

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>

* Change feathr client to mocked object

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>

* Change timeout to 1000s in the notebook

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>

Signed-off-by: Jun Ki Min <42475935+loomlike@users.noreply.github.com>
Signed-off-by: Boli Guan <ifendoe@gmail.com>
Co-authored-by: Blair Chen <blrchen@hotmail.com>
Co-authored-by: Blair Chen <blrchen@users.noreply.github.com>
Co-authored-by: Boli Guan <ifendoe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants