-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix avro files read failure under timePartitionPattern paths #808
Conversation
This reverts commit 155212a.
This reverts commit 585e2ae.
feathr-ai#815)" This reverts commit 6b5cd00.
…d feature (feathr-ai#815)"" This reverts commit 05fa959.
feathr-ai#814)"" This reverts commit 7f68162.
Can docs get updated to give samples on how to use this new params? |
The comments under definition of 'HdfsSource' is the related document update and it can be shown through API document link we exposed. |
Yes, that is what i meant, we should put that in docs because user normally do not read our test code, they read docs. |
The comment was already added in the file 'feathr_project/feathr/definition/source.py' |
I see why you are confused here, might be I didn't explain clearly enough, I meant public docs like this one https://feathr-ai.github.io/feathr/how-to-guides/feathr-input-format.html should be updated for use directories as input source. |
Description
How was this PR tested?
Does this PR introduce any user-facing changes?