Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance error messages of synapse jobs #855

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Enhance error messages of synapse jobs #855

merged 2 commits into from
Nov 14, 2022

Conversation

enya-yx
Copy link
Collaborator

@enya-yx enya-yx commented Nov 13, 2022

Description

  • Add notes for synapse job when size of error messages is out of limit settings.

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

blrchen
blrchen previously approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@blrchen blrchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestion not to add empty spaces at the end of line.

xiaoyongzhu
xiaoyongzhu previously approved these changes Nov 14, 2022
View reviewed changes
@enya-yx enya-yx dismissed stale reviews from xiaoyongzhu and blrchen via c30be26 November 14, 2022 08:55
@enya-yx enya-yx requested a review from blrchen November 14, 2022 10:01
@enya-yx enya-yx merged commit 4e60297 into feathr-ai:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoyongzhu xiaoyongzhu xiaoyongzhu approved these changes

@blrchen blrchen blrchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enya-yx @xiaoyongzhu @blrchen