Fix broken CI tests and test release code #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rakeshkashyap123
commented
Dec 1, 2022
•
rakeshkashyap123
commented
- Test release branch
- Exclude avroutil package from feathr
- Fix broken tests
added 18 commits
December 1, 2022 14:49
xiaoyongzhu
previously approved these changes
Dec 6, 2022
|
Let's get this in, seems we only have one failing test case and let's fix them in the next PR. |
xiaoyongzhu
requested review from
blrchen,
edwincheung,
enya-yx,
hangfei,
jainr,
loomlike,
mufajjul,
windoze and
Yuqing-cat
blrchen
reviewed
Dec 7, 2022
|
Thanks @rakeshkashyap123 for fixing CI issues. Suggest update PR title to mention what this PR is for. I think one of remaining works is update publish-to-maven.yml to publish 4 newly added jar files. |
rakeshkashyap123
changed the title
blrchen
previously approved these changes
Dec 7, 2022
blrchen
approved these changes
Dec 7, 2022
xiaoyongzhu
approved these changes
Dec 7, 2022
jaymo001
pushed a commit
to jaymo001/feathr
that referenced
this pull request
Dec 7, 2022
* Release branch test * Add v to version number * add back some missing dependencies * Add snowflake, cosmos dependencies to buildscript dependency * Fix snowflake version * Add snowflake and cosmos as a dependency * Add few more missing dependencies * Remove META-INF * Add sql server dependency * Add spark-core 3.1 dependency * add spark sql kafka * Add jetty * add compileOnly implementations * Latest version of cosmos * Latest version of cosmos * add sqllite dependency * upgrade to spark 3.2 * Experiment by changing to only provided * Change to implementation of snowflake componenets * update version * Align all implementations before provided in gradle file Co-authored-by: rkashyap <rkashyap@linkedin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.