Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NYC sample notebook feature re-name #991

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

loomlike
Copy link
Collaborator

Description

To make the feature name more straightforward: f_trip_time_distance --> f_trip_speed.

How was this PR tested?

Notebook pytest

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@loomlike loomlike requested a review from blrchen January 18, 2023 17:29
@loomlike loomlike added the safe to test Tag to execute build pipeline for a PR from forked repo label Jan 18, 2023
@blrchen
Copy link
Collaborator

blrchen commented Jan 19, 2023

@xiaoyongzhu do you still have the raw content for the image used in nyc taxi notebook? So we can update the image as well

@loomlike
Copy link
Collaborator Author

@blrchen I did update the image that's included in this PR.

@blrchen blrchen merged commit d869dd3 into feathr-ai:main Jan 19, 2023
xiaoyongzhu added a commit to xiaoyongzhu/feathr that referenced this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants