Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for 'auto' value in 'fold' parameter #755

Merged
merged 23 commits into from May 14, 2024

Conversation

glevv
Copy link
Contributor

@glevv glevv commented May 2, 2024

closes #754

@glevv glevv marked this pull request as ready for review May 2, 2024 14:49
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.23%. Comparing base (a347bc8) to head (6881055).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
+ Coverage   98.18%   98.23%   +0.05%     
==========================================
  Files         105      105              
  Lines        4074     4085      +11     
  Branches      795      799       +4     
==========================================
+ Hits         4000     4013      +13     
+ Misses         29       28       -1     
+ Partials       45       44       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@solegalli
Copy link
Collaborator

Hi @glevv Thank you so much for the super quick turnaround!

Could I ask you an additional change? Could you update the corresponding rst files within the user_guide in the docs file? It'd be important to reflect the current limits, and if you can give a shoutout at the auto parameter it would be great :)

Thank you!

Copy link
Collaborator

@solegalli solegalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @glevv Thank you so much! If we change the wording of fold_ we are good to merge!

@solegalli solegalli changed the title Add support for 'auto' value in 'fold' parameter [MRG] Add support for 'auto' value in 'fold' parameter May 4, 2024
@solegalli
Copy link
Collaborator

Thanks a lot!

@solegalli solegalli changed the title [MRG] Add support for 'auto' value in 'fold' parameter add support for 'auto' value in 'fold' parameter May 14, 2024
@solegalli solegalli merged commit f36e0f3 into feature-engine:main May 14, 2024
10 checks passed
@glevv glevv deleted the fold-auto branch May 14, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants