-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for 'auto' value in 'fold' parameter #755
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
==========================================
+ Coverage 98.18% 98.23% +0.05%
==========================================
Files 105 105
Lines 4074 4085 +11
Branches 795 799 +4
==========================================
+ Hits 4000 4013 +13
+ Misses 29 28 -1
+ Partials 45 44 -1 ☔ View full report in Codecov by Sentry. |
Hi @glevv Thank you so much for the super quick turnaround! Could I ask you an additional change? Could you update the corresponding rst files within the user_guide in the docs file? It'd be important to reflect the current limits, and if you can give a shoutout at the auto parameter it would be great :) Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @glevv Thank you so much! If we change the wording of fold_ we are good to merge!
Thanks a lot! |
closes #754