Fixed: archive count was total accross boards

feature-flow · Jul 2, 2017 · d6cbf77 · d6cbf77
1 parent 67c11d7
commit d6cbf77
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/client/demo/boardapi.js b/client/demo/boardapi.js
@@ -395,7 +395,7 @@ module.exports = class extends BaseAPI {
               const removals = feature.tasks.map((t) => t.id);
               removals.push(feature_id);
               this.remove_all(tasks_store, removals, () => {
-                this.r(archive.count(), (count) => {
+                this.r(archive.index('board').count(this.name), (count) => {
                   const boards = trans.objectStore('boards');
                   this.r(boards.get(this.name), (board) => {
                     board.archive_count = count;
@@ -430,7 +430,7 @@ module.exports = class extends BaseAPI {
           delete feature.tasks;
           tasks.push(feature);
           this.add_all(tasks_store, tasks, () => {
-            this.r(archive.count(), (count) => {
+            this.r(archive.index('board').count(this.name), (count) => {
               const boards = trans.objectStore('boards');
               this.r(boards.get(this.name), (board) => {
                 board.archive_count = count;

diff --git a/client/tests/testdemoboardapi.js b/client/tests/testdemoboardapi.js
@@ -859,6 +859,12 @@ describe("demo board api", () => {
           });
         });
       })
+        .then(() => promise((cb) => {
+          // Archive a feature in an unrelated board to provoke leakage
+          new BoardAPI(view, 'sample', (api) => {
+            api.archive('proto', cb);
+          });
+        }))
         .then(() => promise((cb) => {
           // Move the feature of interest to a different state, to make sure
           // the state is restored correctly