refactor(core): rename first argument of FeatureServiceRegistry const…

…ructor (#249)
feature-hub · Jan 11, 2019 · 2d1933c · 2d1933c
1 parent 92579d9
commit 2d1933c
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 29 deletions.
diff --git a/packages/core/src/__tests__/feature-app-manager.test.ts b/packages/core/src/__tests__/feature-app-manager.test.ts
@@ -15,7 +15,7 @@ interface MockFeatureServiceRegistry extends FeatureServiceRegistryLike {
 
 describe('FeatureAppManager', () => {
   let featureAppManager: FeatureAppManagerLike;
-  let mockRegistry: MockFeatureServiceRegistry;
+  let mockFeatureServiceRegistry: MockFeatureServiceRegistry;
   let mockFeatureServicesBinding: FeatureServicesBinding;
   let mockFeatureServicesBindingUnbind: () => void;
   let mockModuleLoader: ModuleLoader;
@@ -33,7 +33,7 @@ describe('FeatureAppManager', () => {
       unbind: mockFeatureServicesBindingUnbind
     };
 
-    mockRegistry = {
+    mockFeatureServiceRegistry = {
       registerFeatureServices: jest.fn(),
       bindFeatureServices: jest.fn(() => mockFeatureServicesBinding)
     };
@@ -43,7 +43,7 @@ describe('FeatureAppManager', () => {
     mockFeatureAppDefinition = {create: mockFeatureAppCreate, id: 'testId'};
     mockFeatureAppModule = {default: mockFeatureAppDefinition};
     mockModuleLoader = jest.fn(async () => mockFeatureAppModule);
-    featureAppManager = new FeatureAppManager(mockRegistry);
+    featureAppManager = new FeatureAppManager(mockFeatureServiceRegistry);
 
     spyConsoleInfo = jest.spyOn(console, 'info');
     spyConsoleInfo.mockImplementation(jest.fn());
@@ -55,7 +55,7 @@ describe('FeatureAppManager', () => {
 
   describe('#getAsyncFeatureAppDefinition', () => {
     beforeEach(() => {
-      featureAppManager = new FeatureAppManager(mockRegistry, {
+      featureAppManager = new FeatureAppManager(mockFeatureServiceRegistry, {
         moduleLoader: mockModuleLoader
       });
     });
@@ -123,7 +123,7 @@ describe('FeatureAppManager', () => {
       });
 
       it('throws an error if no module loader was provided', () => {
-        featureAppManager = new FeatureAppManager(mockRegistry);
+        featureAppManager = new FeatureAppManager(mockFeatureServiceRegistry);
 
         expect(() =>
           featureAppManager.getAsyncFeatureAppDefinition('/example.js')
@@ -149,7 +149,7 @@ describe('FeatureAppManager', () => {
       const mockConfig = {kind: 'test'};
       const idSpecifier = 'testIdSpecifier';
 
-      featureAppManager = new FeatureAppManager(mockRegistry, {
+      featureAppManager = new FeatureAppManager(mockFeatureServiceRegistry, {
         configs: {[mockFeatureAppDefinition.id]: mockConfig}
       });
 
@@ -158,9 +158,9 @@ describe('FeatureAppManager', () => {
         idSpecifier
       );
 
-      expect(mockRegistry.bindFeatureServices.mock.calls).toEqual([
-        [mockFeatureAppDefinition, idSpecifier]
-      ]);
+      expect(mockFeatureServiceRegistry.bindFeatureServices.mock.calls).toEqual(
+        [[mockFeatureAppDefinition, idSpecifier]]
+      );
 
       const {featureServices} = mockFeatureServicesBinding;
 
@@ -170,20 +170,24 @@ describe('FeatureAppManager', () => {
     });
 
     describe('with a Feature App definition with own Feature Service definitions', () => {
-      let registryMethodCalls: string[];
+      let featureServiceRegistryMethodCalls: string[];
 
       beforeEach(() => {
-        registryMethodCalls = [];
+        featureServiceRegistryMethodCalls = [];
 
-        mockRegistry.registerFeatureServices.mockImplementation(() => {
-          registryMethodCalls.push('registerFeatureServices');
-        });
+        mockFeatureServiceRegistry.registerFeatureServices.mockImplementation(
+          () => {
+            featureServiceRegistryMethodCalls.push('registerFeatureServices');
+          }
+        );
 
-        mockRegistry.bindFeatureServices.mockImplementation(() => {
-          registryMethodCalls.push('bindFeatureServices');
+        mockFeatureServiceRegistry.bindFeatureServices.mockImplementation(
+          () => {
+            featureServiceRegistryMethodCalls.push('bindFeatureServices');
 
-          return mockFeatureServicesBinding;
-        });
+            return mockFeatureServicesBinding;
+          }
+        );
 
         mockFeatureAppDefinition = {
           ...mockFeatureAppDefinition,
@@ -197,15 +201,17 @@ describe('FeatureAppManager', () => {
           'testIdSpecifier'
         );
 
-        expect(mockRegistry.registerFeatureServices.mock.calls).toEqual([
+        expect(
+          mockFeatureServiceRegistry.registerFeatureServices.mock.calls
+        ).toEqual([
           [mockFeatureAppDefinition.ownFeatureServiceDefinitions, 'testId']
         ]);
 
-        expect(mockRegistry.bindFeatureServices.mock.calls).toEqual([
-          [mockFeatureAppDefinition, 'testIdSpecifier']
-        ]);
+        expect(
+          mockFeatureServiceRegistry.bindFeatureServices.mock.calls
+        ).toEqual([[mockFeatureAppDefinition, 'testIdSpecifier']]);
 
-        expect(registryMethodCalls).toEqual([
+        expect(featureServiceRegistryMethodCalls).toEqual([
           'registerFeatureServices',
           'bindFeatureServices'
         ]);
@@ -379,7 +385,7 @@ describe('FeatureAppManager', () => {
 
   describe('#preloadFeatureApp', () => {
     beforeEach(() => {
-      featureAppManager = new FeatureAppManager(mockRegistry, {
+      featureAppManager = new FeatureAppManager(mockFeatureServiceRegistry, {
         moduleLoader: mockModuleLoader
       });
     });
@@ -395,7 +401,7 @@ describe('FeatureAppManager', () => {
     });
 
     it('throws an error if no module loader was provided', () => {
-      featureAppManager = new FeatureAppManager(mockRegistry);
+      featureAppManager = new FeatureAppManager(mockFeatureServiceRegistry);
 
       expect(() =>
         featureAppManager.getAsyncFeatureAppDefinition('/example.js')

diff --git a/packages/core/src/feature-app-manager.ts b/packages/core/src/feature-app-manager.ts
@@ -90,7 +90,7 @@ export class FeatureAppManager implements FeatureAppManagerLike {
   >();
 
   public constructor(
-    private readonly registry: FeatureServiceRegistryLike,
+    private readonly featureServiceRegistry: FeatureServiceRegistryLike,
     private readonly options: FeatureAppManagerOptions = {}
   ) {}
 
@@ -187,7 +187,7 @@ export class FeatureAppManager implements FeatureAppManagerLike {
     }
 
     if (featureAppDefinition.ownFeatureServiceDefinitions) {
-      this.registry.registerFeatureServices(
+      this.featureServiceRegistry.registerFeatureServices(
         featureAppDefinition.ownFeatureServiceDefinitions,
         featureAppDefinition.id
       );
@@ -207,7 +207,7 @@ export class FeatureAppManager implements FeatureAppManagerLike {
     const config = configs && configs[featureAppDefinition.id];
     const featureAppUid = createUid(featureAppDefinition.id, idSpecifier);
 
-    const binding = this.registry.bindFeatureServices(
+    const binding = this.featureServiceRegistry.bindFeatureServices(
       featureAppDefinition,
       idSpecifier
     );

diff --git a/packages/react/src/__tests__/feature-app-container.test.tsx b/packages/react/src/__tests__/feature-app-container.test.tsx
@@ -36,7 +36,7 @@ describe('FeatureAppContainer', () => {
     spyConsoleError.mockRestore();
   });
 
-  it('calls the feature app manager with the given Feature App definition and id specifier', () => {
+  it('calls the Feature App manager with the given Feature App definition and id specifier', () => {
     shallow(
       <FeatureAppContainer
         featureAppManager={mockManager}