Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): remove ability to provide configs via FeatureServiceRegistry #500

Merged
merged 2 commits into from
Jun 5, 2019
Merged

feat(core): remove ability to provide configs via FeatureServiceRegistry #500

merged 2 commits into from
Jun 5, 2019

Commits on Jun 5, 2019

  1. feat(core): remove ability to provide configs via FeatureServiceRegistry 

    BREAKING CHANGE: The option `featureServiceConfigs` has been removed
from the options of `createFeatureHub` and from the options of the
`FeatureServiceRegistry` constructor. The `env` that is passed to a
Feature Service's `create` method does not include a `config` property
anymore. If a Feature Service must be configured, a factory function
that accepts options, and that returns a Feature Service definition,
should be used instead, see @feature-hub/async-ssr-manager for an
example.
    @unstubbable
    unstubbable committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    a7c4b4d View commit details
    Browse the repository at this point in the history

  2. fix(all): rename consumerId to featureAppUid in beforeCreate

    @unstubbable
    unstubbable committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    d090177 View commit details
    Browse the repository at this point in the history