feat(all): add failure option to done call #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unstubbable
requested changes
Jan 11, 2022
unstubbable
requested changes
Jan 27, 2022
With this a feature app can include some other FA to select something and the new FA can signal in the done call if changes should be applied or if it just terminated and nothing should be changed
elbkind
force-pushed
the
add-failure-option-to-done-call
branch
2 times, most recently
from
196f0e3
to
31a1564
Compare
elbkind
force-pushed
the
add-failure-option-to-done-call
branch
from
31a1564
to
c59fc0a
Compare
unstubbable
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this a feature app can include some other FA to select
something and the new FA can signal in the done call if
changes should be applied or if it just terminated and
nothing should be changed