Add strict definitions for layers #547
Conversation
✅ Deploy Preview for pr-fsd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
praise: Написано круто! issue(critical): Но надо что-то сделать тогда с существующими разделами (units-layers-segments) Заменить полностью одно другим / Смержить - иначе дублирование инфы будет опять Иначе юзеры будут путаться опять - какая инфа более актуальная
|
Yeah, they will be purged. I left them for now as reference to finish up the "Slices and segments" page |
| * UI kit | ||
| * API client | ||
| * Code working with browser APIs | ||
| * Routing primitives (e.g., authentication-protected routes) |
There was a problem hiding this comment.
Protected route always depends on some sort of state or bussiness logic from entities (eg. isAuthenticated state flag from '@/entities/session').
People can be confused: bcs they cant import entities into shared.
As a solustion, i suggest move authentication-protected routes up to entities/session/model/**
There was a problem hiding this comment.
Okay, I agree that this isn't a good place for them
i18n/en/docusaurus-plugin-content-docs/current/reference/slices-segments.mdx
Outdated
Show resolved
Hide resolved
Also purge the processes layer
i18n/ru/docusaurus-plugin-content-docs/current/reference/units/index.md
Outdated
Show resolved
Hide resolved
i18n/ru/docusaurus-plugin-content-docs/current/reference/units/layers/index.md
Outdated
Show resolved
Hide resolved
Background
We didn't have precise definitions for layers which led to misinterpretations and questions in communities.
Changelog