Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refresh the FAQ #628

Merged
merged 1 commit into from
Sep 25, 2023
Merged

feat: refresh the FAQ #628

merged 1 commit into from
Sep 25, 2023

Conversation

illright
Copy link
Contributor

@illright illright commented Sep 24, 2023

Background

The old FAQ had several issues:

  1. It contained questions that are no longer being asked, for example, about FSD v1
  2. It wasn't very accurately translated into English
  3. It contained outdated information, for example, about linters and examples
  4. It contained advice that I straight up disagree with, for example, about prohibiting putting feature code directly into pages when it makes sense.

Changelog

Refreshed and rephrased the FAQ

@netlify
Copy link

netlify bot commented Sep 24, 2023

Deploy Preview for pr-fsd ready!

Name Link
🔨 Latest commit f4de779
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/6510975effe9460008d6fe4e
😎 Deploy Preview https://deploy-preview-628--pr-fsd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@illright illright enabled auto-merge (squash) September 24, 2023 20:37
Comment on lines +20 to +23
If you need plain markup layouts, you can keep them in `shared/ui`. If you need to use higher layers inside, there are a few options:

### Are there some useful resources / articles / etc about FSD and related things?
- Perhaps you don't need layouts at all? If the layout is only a few lines, it might be reasonable to duplicate the code in each page rather than try to abstract it.
- If you do need layouts, you can have them as separate widgets or pages, and compose them in your router configuration in App. Nested routing is another option.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@illright illright merged commit 49d6f43 into master Sep 25, 2023
6 checks passed
@illright illright deleted the refresh-faq branch September 25, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants