Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LINT-82(feedback): Import order alphabetic sort, spaces and reverted layers #84

Merged
merged 4 commits into from
Feb 2, 2022
Merged

LINT-82(feedback): Import order alphabetic sort, spaces and reverted layers #84

merged 4 commits into from
Feb 2, 2022

Conversation

Krakazybik
Copy link
Member

@Krakazybik Krakazybik commented Feb 1, 2022 •
edited by azinit

Description

Добавлено:

  • Для стандартного конфига сортировка групп импорта по алфавиту
  • Для экспериментального конфига пробелы между группами и отреверченный порядок слоев
  • Тесты для нововведений

References

#75 #82

Checklist

  • Description added
  • Self-reviewed
  • CI pass

@Krakazybik Krakazybik self-assigned this Feb 1, 2022
@Krakazybik Krakazybik added the feature New feature or request label Feb 1, 2022
@Krakazybik Krakazybik linked an issue Feb 1, 2022 that may be closed by this pull request
LINT: (Feedback) Refine import/order boundaries #82
Closed
2 tasks
azinit
azinit approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Все в лучшем виде)
Все придирки - чисто для улучшения

rules/import-order/experimental.js Outdated Show resolved Hide resolved
rules/import-order/experimental.js Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
rules/import-order/experimental.test.js Outdated Show resolved Hide resolved
rules/import-order/index.test.js Outdated Show resolved Hide resolved
rules/import-order/index.test.js Outdated Show resolved Hide resolved
rules/import-order/index.test.js Outdated Show resolved Hide resolved
rules/import-order/experimental.test.js Outdated Show resolved Hide resolved
rules/integration.test.js Show resolved Hide resolved
@azinit
Copy link
Member

azinit commented Feb 2, 2022

@SQReder @tednaaa Если есть желание - можете тоже глянуть
Мб будет что добавить 🤔

@azinit azinit changed the title LINT-82(feedback): Import order alphabetic sort and spaces LINT-82(feedback): Import order alphabetic sort, spaces and reverted layers Feb 2, 2022
azinit
azinit approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно вливать)

README.md Outdated Show resolved Hide resolved
rules/import-order/experimental.test.js Outdated Show resolved Hide resolved
rules/import-order/index.test.js Outdated Show resolved Hide resolved
rules/import-order/index.test.js Outdated Show resolved Hide resolved
@SQReder
Copy link

SQReder commented Feb 2, 2022

Мне нечего добавить, по-существу. Можно вливать

@azinit azinit merged commit 133ca86 into master Feb 2, 2022
@azinit azinit deleted the feat/LINT-75-improve-import-order branch February 2, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azinit azinit azinit approved these changes

Assignees

@Krakazybik Krakazybik

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LINT: (Feedback) Refine import/order boundaries
3 participants
@Krakazybik @azinit @SQReder