Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patched 0.7.4 #798

Open
kaorahi opened this issue Oct 24, 2020 · 41 comments
Open

Patched 0.7.4 #798

kaorahi opened this issue Oct 24, 2020 · 41 comments

Comments

@kaorahi
Copy link
Contributor

kaorahi commented Oct 24, 2020

Again, I merged most pull requests after 0.7.4 into my unofficial branch "patched_0.7.4" for convenience.

https://github.com/kaorahi/lizzie/tree/patched_0.7.4 (Windows binary: #886)

I cannot offer its binary by myself since I have no Windows machine.

Included patches without PRs

Excluded items

@bdrose
Copy link

bdrose commented Oct 29, 2020

@kaorahi I have compiled it for Windows and could provide the binary. I am competent enough to compile it , since it is easy, but not knowledgeable to all the things I would need to provide to validate that it is legitimate, so would need some guidance there.

@featurecat
Copy link
Owner

Thank you again. I'll add this during the weekend!

@kaorahi
Copy link
Contributor Author

kaorahi commented Nov 2, 2020

Merged #800 and #802.

@kaorahi
Copy link
Contributor Author

kaorahi commented Nov 14, 2020

Merged #801, #807, and #811.

@kaorahi
Copy link
Contributor Author

kaorahi commented Nov 18, 2020

Merged #812, #813, #814, #816, and #782 again for the additional fix c500a89.

@kaorahi
Copy link
Contributor Author

kaorahi commented Dec 5, 2020

Merged #804, #809, #817, #819, #821, #822, and #823. Please let me know if they cause any problem.

@bdrose
Copy link

bdrose commented Dec 5, 2020

@kaorahi Thanks. Running this now.

@kaorahi
Copy link
Contributor Author

kaorahi commented Dec 9, 2020

Merged #824 and #827.

@kaorahi
Copy link
Contributor Author

kaorahi commented Dec 25, 2020

Merged #833, #834, #835, #836, and #837.

@kaorahi
Copy link
Contributor Author

kaorahi commented Dec 29, 2020

Merged #839.

@kaorahi
Copy link
Contributor Author

kaorahi commented Jan 5, 2021

Merged #840, #842 and updated contributors.

@kaorahi
Copy link
Contributor Author

kaorahi commented Jan 31, 2021

Merged #844, #848, #854, #855, #856, #857, applied #825, and updated contributors.

@kaorahi
Copy link
Contributor Author

kaorahi commented Feb 1, 2021

Merged #833 again for a fix. thx! > @bdrose

@kaorahi
Copy link
Contributor Author

kaorahi commented Feb 3, 2021

Merged #860, #861, and #833 yet again for another fix.

@xyproto
Copy link

xyproto commented Feb 5, 2021

#843 is not mainly about the keyboard layout being Norwegian but about the key bindings being non-standard and not configurable.

@kaorahi
Copy link
Contributor Author

kaorahi commented Feb 5, 2021

Then it would be better to make another issue with a proper title. :)

@xyproto
Copy link

xyproto commented Feb 5, 2021

Sure, I was just commenting on the "Not so serious?" remark.

@kaorahi
Copy link
Contributor Author

kaorahi commented Feb 10, 2021

Merged #864, #865, #866, #867, and #848 again for the fix 1e6ba97.

@kaorahi
Copy link
Contributor Author

kaorahi commented Feb 17, 2021

Merged #872, #873, #874, and #848 yet again for the fix 294214e.

@kaorahi
Copy link
Contributor Author

kaorahi commented Mar 12, 2021

Merged #878, #879, and #848 yet yet again for the fix 13e1a36.

@kaorahi
Copy link
Contributor Author

kaorahi commented Mar 19, 2021

Merged #880.

@featurecat, are you still planning to release Lizzie 0.7.5? If so, it may be good timing now. Bug reports to Lizzie have calmed down recently and new KataGo was released for stronger networks via distributed training.

@featurecat
Copy link
Owner

featurecat commented Mar 19, 2021

Ok, I'll review the changes this weekend to release the next version. Thank you for all your hard work. (edit: I got a bit too busy last weekend, but don't worry, I won't forget).

@featurecat
Copy link
Owner

featurecat commented May 9, 2021

I've been stressed because I don't have much time and I'm not that experienced with git - does anyone know how to merge @kaorahi's branch into Lizzie's main repository? I think I had to do it last time but I can't remember.

@kaorahi
Copy link
Contributor Author

kaorahi commented May 9, 2021

Simply merge #884 on github?

Or...

git remote add kaorahi https://github.com/kaorahi/lizzie
git fetch kaorahi
git checkout master
git merge kaorahi/patched_0.7.4
git push origin master

@kaorahi
Copy link
Contributor Author

kaorahi commented Jun 30, 2021

@featurecat, how about releasing Lizzie 0.7.5 with new stronger KataGo 1.9.1?

@ivysrono
Copy link
Contributor

Maybe it's easier and more effective to give @kaorahi access to commit and release.

@featurecat
Copy link
Owner

Excellent idea. @kaorahi I've invited you as a collaborator, if you are interested!

@kaorahi
Copy link
Contributor Author

kaorahi commented Jul 1, 2021

Not so good idea, unfortunately. I'd like to stay just a contributor in this project.

I enjoy developing another GUI and never use Lizzie for myself now. In addition, I cannot build/test Windows binaries as I have no Windows machine.

(But I am still well disposed to Lizzie project and happy to see its wide use, e.g., in the official lives of recent title matches. https://youtu.be/3uuHtBhnM-8?t=10896)

@kaorahi
Copy link
Contributor Author

kaorahi commented Jul 4, 2021

Add Windows binary (#886).

...But I'm still looking forward to official Lizzie 0.7.5 by featurecat or someone who is familiar with Lizzie and Windows.

@kaorahi
Copy link
Contributor Author

kaorahi commented Jul 10, 2021

@kaorahi
Copy link
Contributor Author

kaorahi commented Aug 26, 2021

Merged #890 and #893. Updated Windows binary.

@kaorahi
Copy link
Contributor Author

kaorahi commented Aug 27, 2021

Added 6b9e5a4 for #893 (comment) . I'm not going to make a PR for it because of annoying conflicts.

@kaorahi
Copy link
Contributor Author

kaorahi commented Aug 31, 2021

Merged #802 and #893 again for a bug fix and an additional feature.

@kaorahi
Copy link
Contributor Author

kaorahi commented Sep 1, 2021

Merged #895, #896, and #802 yet again for the correct fix.

@kaorahi
Copy link
Contributor Author

kaorahi commented Sep 12, 2021

Merged #897, #898, and #834 again for bug fix. Updated Windows binary.

@kaorahi
Copy link
Contributor Author

kaorahi commented Oct 26, 2021

Merged #899 and #900. Updated Windows binary with new KataGo 1.10.0.

@kaorahi
Copy link
Contributor Author

kaorahi commented Nov 13, 2021

Merged #904 and #827 again for further fix. Updated Windows binary.

@kaorahi
Copy link
Contributor Author

kaorahi commented Dec 11, 2021

Merged #906 and updated Windows binary.

@kaorahi
Copy link
Contributor Author

kaorahi commented May 10, 2022

Merged #782 yet again for another fix. Updated Windows binary with KataGo 1.11.0.

@kaorahi
Copy link
Contributor Author

kaorahi commented Dec 31, 2023

https://github.com/kaorahi/lizzie/releases/tag/patched074_231231a

Merged #910, #912, #915, #920, #921, and #787 again for #917.

new feature:

d4d0b98 Add stone entropy to winrate graph (imported from LizGoban)

If this feature is activated via the menu (View > KataGo settings > Estimate info > Show stone entropy), red dots will be plotted on the winrate chart. Their height indicates the uncertainty of the stones' life/death status. They tend to be higher in heated situations involving large capturing races or miai. Should they not be displayed, open the menu (View > KataGo settings > Estimate info > Display) and enable it.

This feature was imported from LizGoban. (I am giving up on integrating this feature into the original Lizzie, as it depends on other proposed changes that have not yet been accepted.)

@kaorahi
Copy link
Contributor Author

kaorahi commented Jul 20, 2024

https://github.com/kaorahi/lizzie/releases/tag/patched074_240720b

new feature:

7f6c672 Add "Set humanSL profile" to "Game" menu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants