Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region of interest #833

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Region of interest #833

wants to merge 3 commits into from

Conversation

kaorahi
Copy link
Contributor

@kaorahi kaorahi commented Dec 25, 2020

This is a better implementation of #828, "Set region of interest like KaTrain 1.7".

  • Alt+drag to set region of interest.
  • Alt+click to reset it.

kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request Dec 25, 2020
@kaorahi kaorahi mentioned this pull request Dec 25, 2020
kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request Feb 1, 2021
@kaorahi
Copy link
Contributor Author

kaorahi commented Feb 1, 2021

Fixed a very stupid mistake.

@hope366
Copy link

hope366 commented Feb 1, 2021

I'm using allow0, so around line 190 of BoardDate.java looks like the screenshot below It has become.
That is, there is no if (! Lizzie.board.regionOfInterest.isEnabled ()) return;.
In this case, what changes should I make to solve the winning percentage graph problem?

@yzyray
Copy link
Contributor

yzyray commented Feb 2, 2021

maybe need fix #858

@kaorahi
Copy link
Contributor Author

kaorahi commented Feb 3, 2021

Imported yzyray/lizzie@a7bee3b6 to fix #858 (unintentional drag). thx!

kaorahi pushed a commit to kaorahi/lizzie that referenced this pull request Feb 3, 2021
@hope366
Copy link

hope366 commented Feb 3, 2021

I tried 6bead84, but the bug that the winning percentage graph does not work has not been fixed ...
Just in case, I downloaded https://github.com/kaorahi/lizzie/tree/allow1, compiled and tried it, but it seems that the bug of the winning percentage graph is not fixed like 6bead84.

@kaorahi
Copy link
Contributor Author

kaorahi commented Feb 5, 2021

I disabled updating of the winrate graph in the restricted analysis to avoid confusion with the full analysis. This is not a bug but the intentional behavior.

BTW, I recommend to revert allow0 branch (#828) and use allow1 branch (#833) instead for the future. I won't support allow0 anymore.

@hope366
Copy link

hope366 commented Feb 5, 2021

I disabled updating of the winrate graph in the restricted analysis to avoid confusion with the full analysis. This is not a bug but the intentional behavior.

OK.
It seemed that allow_1 was used in Pached 0.7.4, so I switched to allow_1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants