Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: New UI - Multiple independent panels that can be dragged out #513

Merged
merged 34 commits into from
Jun 25, 2019

Conversation

zsalch
Copy link
Contributor

@zsalch zsalch commented Mar 31, 2019

I tried to develop a new UI layout that used multiple independent panes that can be dragged out.

Split the original single frame into the following panes:
Main Board
Basic Info
Winrate
Sub Board
Variation Tree
Comment
image

This will refresh the individual Pane.
I wrote a simple layout manager that currently only implements the current layout and needs further optimization.

At the same time, each Pane, like the JToolBar, can be dragged out to be a separate window so that we can display them on different displays. The window will restore a pane when the window be closed.
image

Possible problems and next steps:

  1. Need a better background implementation;
  2. Need a better layout manager;
  3. It is best to optimize the current source structure;
  4. Need more tests to find hidden problems.

This is a test version that can be run and looks forward to a better implementation.

@featurecat
Copy link
Owner

Wow, cool! Even if we don't finish the fully correct implementation, it can be a Config setting. I'll take a look

@featurecat
Copy link
Owner

featurecat commented Apr 1, 2019

I am getting the compile error: Error:(41, 17) java: package sun.swing does not exist, in BasicLizziePaneUI

Do you know what is wrong?

I tried a few different JDK compliance levels (11, 8, 7)

@zsalch
Copy link
Contributor Author

zsalch commented Apr 1, 2019

I just temporarily removed the package sun.swing, please try again.

@featurecat
Copy link
Owner

It's really cool, but, appears quite glitchy right now. In the backgrounds of each component now, I can see a glitched version of the board.. and the Lizzie backgrounds etc aren't working correctly. Key commands aren't working (for example I can't use the up arrow to undo). Dragging anywhere moves the pane, when that's not desirable. Note that in 0.7 release, dragging on the board will be the way you enable avoid-moves and search-moves from your other PR.

Is it possible to fix some of these issues? I want to include it as an optional but nondefault feature.

image

@zsalch
Copy link
Contributor Author

zsalch commented Apr 2, 2019

  1. It is not dragable by default. It can only be dragged when you press a special key (for example: Alt+W). The panels will change to the design mode. After the drag is complete, press (Alt+W) again to exit the design mode.

  2. Fixed the Key Issue.

  3. I will check the background issue.

@featurecat
Copy link
Owner

it was draggable by default for me...

@zsalch
Copy link
Contributor Author

zsalch commented Apr 2, 2019

I adjusted the background display issue. It seems to have improved.

@zsalch
Copy link
Contributor Author

zsalch commented Apr 2, 2019

it was draggable by default for me...

This is a bit strange, I have commented the event registration code.
The status can be changed when press the 'Alt+W'?

@zsalch
Copy link
Contributor Author

zsalch commented Apr 3, 2019

Fixed the Background Issue.

@zsalch
Copy link
Contributor Author

zsalch commented Apr 4, 2019

Save/Restore the Window & Pane Position

@zsalch
Copy link
Contributor Author

zsalch commented Apr 6, 2019

Add Background Process.

@zsalch
Copy link
Contributor Author

zsalch commented Apr 7, 2019

Can turn off design mode when press Alt+W in the LizziePane.

@zsalch
Copy link
Contributor Author

zsalch commented Apr 7, 2019

It might be more clear to just use an icon to mark the analysis status.
But I am not sure where to add, what way will be better.
Any good suggestions for everyone?
@ParmuzinAlexander @gogre
Add the status indicator:
image
image

@featurecat
Copy link
Owner

Interesting idea but the icon has to be self explanatory. I'm not sure what the best way is either. I'll test this PR tonight, thanks for all the updates. Hopefully everything is fixed.

@gogre

This comment has been minimized.

@featurecat
Copy link
Owner

The panels look strange due to no background transparency. Is there a way to make them at least have the same background texture? Or to look normal when they are not in the window pane mode?

image

@featurecat

This comment has been minimized.

@zsalch
Copy link
Contributor Author

zsalch commented Apr 9, 2019

I will try to append background transparency if this is necessary.
Also, are there any screenshots for me to understand?

@featurecat
Copy link
Owner

I think if the background textures are not visible, it will make some nice themes look uglier. It would be best to make them transparent.

@featurecat
Copy link
Owner

Yes the screenshot is just to show that my backgrounds were not rendering the same as before.

@zsalch
Copy link
Contributor Author

zsalch commented Apr 9, 2019

Added the pane background transparency process.

@zsalch
Copy link
Contributor Author

zsalch commented Apr 10, 2019

Update Pane Background Transparency Process & Fixed Draw Controls.

@zsalch zsalch merged commit b8210bc into featurecat:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants