Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Ensure each transformation function argument has an input #1018

Merged
merged 7 commits into from
Sep 28, 2023

Conversation

aolfat
Copy link
Contributor

@aolfat aolfat commented Sep 27, 2023

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@aolfat aolfat force-pushed the bugfix/218/df_transformation_arugments branch from 6b00a51 to 1c11d92 Compare September 27, 2023 23:16
@aolfat aolfat changed the title Bugfix: Ensure each function argument has an input Bugfix: Ensure each transformation function argument has an input Sep 27, 2023
@aolfat aolfat temporarily deployed to Integration testing September 27, 2023 23:25 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing September 27, 2023 23:25 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing September 27, 2023 23:25 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing September 27, 2023 23:25 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #1018 (b3dbe6b) into main (2a2eea6) will increase coverage by 0.65%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
+ Coverage   47.75%   48.41%   +0.65%     
==========================================
  Files         110      110              
  Lines       20853    20855       +2     
==========================================
+ Hits         9959    10097     +138     
+ Misses      10212    10069     -143     
- Partials      682      689       +7     
Files Coverage Δ
client/src/featureform/register.py 65.28% <60.00%> (-0.03%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aolfat aolfat temporarily deployed to Integration testing September 28, 2023 17:12 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing September 28, 2023 17:12 — with GitHub Actions Inactive
@aolfat aolfat force-pushed the bugfix/218/df_transformation_arugments branch from ff679c8 to 96e3140 Compare September 28, 2023 17:45
@aolfat aolfat temporarily deployed to Integration testing September 28, 2023 17:50 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing September 28, 2023 18:06 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing September 28, 2023 18:06 — with GitHub Actions Inactive
@aolfat aolfat merged commit 1d091cc into main Sep 28, 2023
42 of 50 checks passed
@aolfat aolfat deleted the bugfix/218/df_transformation_arugments branch September 28, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants