Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource type in title. #1024

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Add resource type in title. #1024

merged 1 commit into from
Sep 29, 2023

Conversation

anthonylasso
Copy link
Contributor

Description

Screenshot 2023-09-28 at 10 57 32 AM

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@anthonylasso anthonylasso temporarily deployed to Integration testing September 28, 2023 16:05 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing September 28, 2023 16:05 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing September 28, 2023 16:05 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing September 28, 2023 16:05 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #1024 (6f99b74) into main (aadfcfa) will decrease coverage by 2.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
- Coverage   48.42%   46.06%   -2.36%     
==========================================
  Files         110      110              
  Lines       20849    20849              
==========================================
- Hits        10096     9605     -491     
- Misses      10063    10609     +546     
+ Partials      690      635      -55     

see 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anthonylasso anthonylasso merged commit 6ccac64 into main Sep 29, 2023
44 of 53 checks passed
@anthonylasso anthonylasso deleted the feature/resourceTypeTitle branch September 29, 2023 23:32
sdreyer pushed a commit that referenced this pull request Sep 30, 2023
RiddhiBagadiaa pushed a commit that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants