Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamically set table sizes #1030

Merged
merged 2 commits into from
Sep 28, 2023
Merged

dynamically set table sizes #1030

merged 2 commits into from
Sep 28, 2023

Conversation

anthonylasso
Copy link
Contributor

@anthonylasso anthonylasso commented Sep 28, 2023

Description

Dynamically set the main table and variant table sizes.

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

-based on the incoming list lengths
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #1030 (395b7e6) into main (f242ee0) will increase coverage by 29.40%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1030       +/-   ##
===========================================
+ Coverage   37.84%   67.24%   +29.40%     
===========================================
  Files         110       43       -67     
  Lines       20855     5792    -15063     
===========================================
- Hits         7893     3895     -3998     
+ Misses      12607     1877    -10730     
+ Partials      355       20      -335     

see 68 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anthonylasso anthonylasso merged commit 6c4b4a2 into main Sep 28, 2023
9 of 20 checks passed
@anthonylasso anthonylasso deleted the bugfix/resourceTableSize branch September 28, 2023 20:59
@anthonylasso anthonylasso temporarily deployed to Integration testing September 28, 2023 21:02 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing September 28, 2023 21:02 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing September 28, 2023 21:02 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing September 28, 2023 21:02 — with GitHub Actions Inactive
sdreyer pushed a commit that referenced this pull request Sep 29, 2023
RiddhiBagadiaa pushed a commit that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants