Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix state error for resource redefined error #1032

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Conversation

aolfat
Copy link
Contributor

@aolfat aolfat commented Sep 29, 2023

This was how to recreate the problem:

  • register file
  • register file again with different name
  • apply (you get a failure)
  • reregister file and re apply and it fails

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@aolfat aolfat temporarily deployed to Integration testing September 29, 2023 04:48 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing September 29, 2023 04:48 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing September 29, 2023 04:48 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #1032 (7e770dd) into main (6c4b4a2) will increase coverage by 0.54%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
+ Coverage   42.20%   42.75%   +0.54%     
==========================================
  Files         110      110              
  Lines       20855    20855              
==========================================
+ Hits         8802     8916     +114     
+ Misses      11549    11277     -272     
- Partials      504      662     +158     
Files Coverage Δ
client/src/featureform/register.py 65.28% <100.00%> (ø)

... and 30 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aolfat aolfat merged commit 7578b76 into main Sep 29, 2023
17 of 21 checks passed
@aolfat aolfat deleted the bugfix/state_error branch September 29, 2023 17:18
@aolfat aolfat temporarily deployed to Integration testing September 29, 2023 20:32 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing September 29, 2023 20:32 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing September 29, 2023 20:32 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants