Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Issue with source not retrieving any source #1034

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

ahmadnazeri
Copy link
Contributor

Check to see if source definition is DFTransformation before accessing source_text field

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@crfeliz crfeliz force-pushed the bug-fix/check_source_text_field_available branch from 8afec83 to c413a83 Compare September 29, 2023 18:01
@anthonylasso anthonylasso merged commit 398bb9a into main Sep 29, 2023
14 of 18 checks passed
@anthonylasso anthonylasso deleted the bug-fix/check_source_text_field_available branch September 29, 2023 19:08
@crfeliz crfeliz temporarily deployed to Integration testing September 29, 2023 19:15 — with GitHub Actions Inactive
@crfeliz crfeliz temporarily deployed to Integration testing September 29, 2023 19:15 — with GitHub Actions Inactive
@crfeliz crfeliz temporarily deployed to Integration testing September 29, 2023 19:15 — with GitHub Actions Inactive
@crfeliz crfeliz temporarily deployed to Integration testing September 29, 2023 19:15 — with GitHub Actions Inactive
sdreyer pushed a commit that referenced this pull request Sep 29, 2023
Co-authored-by: Carlos R. Feliz <carlos@featureform.com>
RiddhiBagadiaa pushed a commit that referenced this pull request Oct 17, 2023
Co-authored-by: Carlos R. Feliz <carlos@featureform.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants