Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh and Loading fix #1039

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Refresh and Loading fix #1039

merged 1 commit into from
Sep 29, 2023

Conversation

anthonylasso
Copy link
Contributor

Description

This PR fixes an issue that causes a "404" message to display when hard refreshing the page. Now the loading dots correctly display until the resources is fully loaded.

example slowed to 'Fast 3g'

Screen.Recording.2023-09-29.at.3.52.38.PM.mov

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@anthonylasso anthonylasso merged commit f0ed6eb into main Sep 29, 2023
17 of 21 checks passed
@anthonylasso anthonylasso deleted the bugfix/404whenLoading branch September 29, 2023 23:32
@anthonylasso anthonylasso temporarily deployed to Integration testing September 30, 2023 01:17 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing September 30, 2023 01:17 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing September 30, 2023 01:17 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing September 30, 2023 01:17 — with GitHub Actions Inactive
sdreyer pushed a commit that referenced this pull request Sep 30, 2023
RiddhiBagadiaa pushed a commit that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants