Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved caching for docker rebuilds #1043

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Conversation

sdreyer
Copy link
Collaborator

@sdreyer sdreyer commented Sep 30, 2023

Description

Drops docker rebuild time for ~10 minutes to ~1:30

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@sdreyer sdreyer temporarily deployed to Integration testing September 30, 2023 07:53 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing September 30, 2023 07:53 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #1043 (44fae4b) into main (d3071da) will decrease coverage by 1.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
- Coverage   46.08%   44.24%   -1.85%     
==========================================
  Files         110      110              
  Lines       20847    20847              
==========================================
- Hits         9607     9223     -384     
- Misses      10606    11023     +417     
+ Partials      634      601      -33     

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sdreyer sdreyer merged commit fe13bfe into main Sep 30, 2023
28 of 50 checks passed
@sdreyer sdreyer deleted the other/better-docker-caching branch September 30, 2023 21:53
sdreyer added a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants