Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mysql offline store #1074

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

jerempy
Copy link
Contributor

@jerempy jerempy commented Oct 9, 2023

Description

Adds mySQL as offline store

There are some aspects of mySQL that differ from postgresql. For example mySQL doesn't have materialized views. But the offlinestore interface has several methods centered around materialized views. I incorporated simiarl/close to functionality with mySQL views - but it just not exactly the same. Where possible got close approximations of the behavior of the interface methods and did implement all methods to satisfy the interface definition.

Type of change

Feature: Include mySQL and the go mySQL driver as option for offline store

Does this correspond to an open issue?

Closes: #1069

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@simba-git
Copy link
Contributor

Thanks for the PR!

@sdreyer sdreyer merged commit a080a6e into featureform:main Oct 11, 2023
sdreyer pushed a commit that referenced this pull request Oct 25, 2023
RiddhiBagadiaa pushed a commit that referenced this pull request Nov 16, 2023
@@ -20,6 +20,7 @@ func init() {
pt.DynamoDBOnline: dynamodbOnlineStoreFactory,
pt.PineconeOnline: pineconeOnlineStoreFactory,
pt.MemoryOffline: memoryOfflineStoreFactory,
pt.MySqlOffline: memoryOfflineStoreFactory,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🎃[Feature Request]: Implement MySQL as an Offline Store
4 participants