Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider Health Checks #1085

Merged
merged 21 commits into from
Nov 2, 2023
Merged

Provider Health Checks #1085

merged 21 commits into from
Nov 2, 2023

Conversation

epps
Copy link
Contributor

@epps epps commented Oct 16, 2023

Description

This PR introduces a Check method on the Provider interface, with implementations for:

  • Redis
  • DynamoDB
  • Snowflake
  • Spark
  • PostgreSQL

Additionally, the health package is introduced to handle processing health checks by provider name. In the near feature, this package will become a standalone service to facilitate runner provider health checks on a schedule.

Type of change

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@epps epps requested a review from sdreyer October 16, 2023 23:09
health/health.go Outdated Show resolved Hide resolved
provider/provider.go Outdated Show resolved Hide resolved
@epps epps temporarily deployed to Integration testing October 17, 2023 00:32 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing October 17, 2023 00:32 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1085 (0f6f53f) into main (699a397) will decrease coverage by 1.16%.
Report is 12 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
- Coverage   31.11%   29.96%   -1.16%     
==========================================
  Files          76       76              
  Lines       15672    15727      +55     
==========================================
- Hits         4877     4713     -164     
- Misses      10321    10521     +200     
- Partials      474      493      +19     
Files Coverage Δ
provider/bigquery.go 3.42% <0.00%> (-0.01%) ⬇️
provider/blob_online.go 0.00% <0.00%> (ø)
provider/cassandra.go 0.00% <0.00%> (ø)
provider/firestore.go 0.00% <0.00%> (ø)
provider/k8s.go 1.79% <0.00%> (-0.01%) ⬇️
provider/mongodb.go 0.00% <0.00%> (ø)
provider/offline.go 32.22% <0.00%> (-3.49%) ⬇️
provider/online.go 69.38% <0.00%> (-7.21%) ⬇️
provider/pinecone.go 0.00% <0.00%> (ø)
provider/provider.go 84.44% <0.00%> (-3.93%) ⬇️
... and 7 more

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Makefile Outdated Show resolved Hide resolved
health/health.go Show resolved Hide resolved
provider/provider.go Outdated Show resolved Hide resolved
@epps epps temporarily deployed to Integration testing October 18, 2023 04:12 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing October 18, 2023 04:12 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing October 18, 2023 20:19 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing October 18, 2023 20:20 — with GitHub Actions Inactive
@epps epps force-pushed the feature/provider-healthchecks branch from 1afe98c to ff5f4cc Compare October 18, 2023 23:44
@epps epps temporarily deployed to Integration testing October 19, 2023 00:55 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 1, 2023 22:24 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 1, 2023 22:24 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 1, 2023 22:24 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 1, 2023 22:57 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 1, 2023 22:57 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 1, 2023 22:57 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 1, 2023 22:57 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 1, 2023 22:57 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 1, 2023 23:29 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 1, 2023 23:29 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 1, 2023 23:29 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 1, 2023 23:29 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 1, 2023 23:29 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 1, 2023 23:29 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 1, 2023 23:29 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 2, 2023 00:00 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 2, 2023 00:00 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 2, 2023 00:00 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 2, 2023 00:00 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 2, 2023 00:00 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 2, 2023 00:00 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing November 2, 2023 00:00 — with GitHub Actions Inactive
@epps epps merged commit 4ffd4a9 into main Nov 2, 2023
41 checks passed
@epps epps deleted the feature/provider-healthchecks branch November 2, 2023 00:09
RiddhiBagadiaa pushed a commit that referenced this pull request Nov 16, 2023
@epps epps mentioned this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants